Skip to content

Add capnproto as submodule #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acomodi
Copy link
Collaborator

@acomodi acomodi commented Oct 12, 2021

Description

This PR does the following:

  • removes all committed files coming from a third party repository (namely capnproto) and adds a submodule instead
  • adds the submodule initialization step in the makefile and the various GH action jobs

Motivation and Context

I am not entirely sure why all the external libraries have been committed in the VTR codebase, but I think that it should be much easier to handle third party projects with submodules, so that, in case we need to update them, we can just bump the submodule instead of committing the changes that do happen upstream.

How Has This Been Tested?

regression tests

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added build Build system external_libs infra Project Infrastructure lang-make CMake/Make code labels Oct 12, 2021
@acomodi acomodi requested a review from vaughnbetz October 13, 2021 06:52
@acomodi acomodi force-pushed the add-capnproto-as-submodule branch from cc12c00 to 24c85e2 Compare October 13, 2021 07:59
@acomodi acomodi force-pushed the add-capnproto-as-submodule branch from 24c85e2 to 65bda13 Compare October 14, 2021 08:31
@acomodi
Copy link
Collaborator Author

acomodi commented Oct 14, 2021

@vaughnbetz CI went green. If everything looks good I'd merge this one

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this does cut a lot of files!
LGTM

@vaughnbetz vaughnbetz merged commit 5409e84 into verilog-to-routing:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system external_libs infra Project Infrastructure lang-make CMake/Make code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants